fix: Median() integer overflow #19509
Open
+76
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When calculating the median of an even-length array of integers, averaging the two middle values using
add_wrappingcauses incorrect results due to integer overflow.For example, with Int8 values -85 and -56:
What changes are included in this PR?
Fix
calculate_median: Use add_checked to detect overflow, and fall back to a safe midpoint formulaa/2 + b/2 + ((a%2 + b%2) / 2)when overflow occurs.Add tests
Are these changes tested?
Are there any user-facing changes?