Skip to content

docs : clarify unused test utility #19508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dandandan merged 8 commits into from
Dec 28, 2025
Merged

docs : clarify unused test utility #19508

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3c67c45
docs : clarify unused test utility
Nachiket-Roy Dec 27, 2025
04d7855
Merge branch 'main' into docs/unused-test
Nachiket-Roy Dec 27, 2025
6744a00
Merge branch 'main' into docs/unused-test
Nachiket-Roy Dec 27, 2025
9aacabb
fix : allow to expect
Nachiket-Roy Dec 27, 2025
4a58c64
Merge branch 'main' into docs/unused-test
Nachiket-Roy Dec 27, 2025
96f235e
revert to allow(dead_code)
Nachiket-Roy Dec 27, 2025
a7cf2a4
Merge branch 'main' into docs/unused-test
Nachiket-Roy Dec 27, 2025
7861353
conditionally expect dead_code for FFI test helper
Nachiket-Roy Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions datafusion/ffi/tests/utils/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ use datafusion_ffi::execution::FFI_TaskContextProvider;
use datafusion_ffi::proto::logical_extension_codec::FFI_LogicalExtensionCodec;
use datafusion_proto::logical_plan::DefaultLogicalExtensionCodec;

// Creates a default SessionContext and FFI Logical Extension Codec
// for use in FFI integration tests.
//
// This helper centralizes setup logic and is kept intentionally
// for upcoming FFI test expansions.
#[cfg_attr(not(feature = "integration-tests"), expect(dead_code))]
pub fn ctx_and_codec() -> (Arc<SessionContext>, FFI_LogicalExtensionCodec) {
let ctx = Arc::new(SessionContext::default());
let task_ctx_provider = Arc::clone(&ctx) as Arc<dyn TaskContextProvider>;
Expand Down