Various refactors to string functions #19402
Open
+56
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Dec 19, 2025
| if arg_types[0] == DataType::Utf8View { | ||
| Ok(DataType::Utf8View) | ||
| } else { | ||
| utf8_to_str_type(&arg_types[0], "ltrim") |
Contributor
Author
There was a problem hiding this comment.
utf8_to_str_type() preserves type to LargeUtf8 if input is large, otherwise just Utf8; we can see we also preserve view type, so in this case we are just preserving the input type as is
| TypeSignature::Exact(vec![LargeUtf8, Utf8, Int64]), | ||
| TypeSignature::Exact(vec![Utf8, LargeUtf8, Int64]), | ||
| TypeSignature::Exact(vec![LargeUtf8, LargeUtf8, Int64]), | ||
| Coercion::new_exact(TypeSignatureClass::Native(logical_string())), |
| UInt16 => make_scalar_function(to_hex::<UInt16Type>, vec![])(&args.args), | ||
| Int8 => make_scalar_function(to_hex::<Int8Type>, vec![])(&args.args), | ||
| UInt8 => make_scalar_function(to_hex::<UInt8Type>, vec![])(&args.args), | ||
| DataType::Null => Ok(ColumnarValue::Scalar(ScalarValue::Utf8(None))), |
Contributor
Author
There was a problem hiding this comment.
I prefer having the DataType:: but this is just personal preference, can revert if is too verbose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Clean up some signatures & unnecessary code in string functions
What changes are included in this PR?
Various refactors, see comments.
Are these changes tested?
Existing tests.
Are there any user-facing changes?
No.