Skip to content

Keep the parentheses of an empty CREATE PROCEDURE parameter list - #2756

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
upstream/procedure-empty-parameter-list
Oct 29, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
upstream/procedure-empty-parameter-list

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

CREATE PROCEDURE p () AS BEGIN SELECT 1; END printed as CREATE PROCEDURE p AS BEGIN SELECT 1; END. The parser returned Some(vec![]) both for () and for a procedure without a parameter list, and Display skipped an empty list. PostgreSQL requires the parentheses (https://www.postgresql.org/docs/current/sql-createprocedure.html), so the printed statement was not valid there.

@LucaCappelletti94 LucaCappelletti94 added bug Something isn't working api change labels Oct 28, 2026
@codecov-commenter

codecov-commenter commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.47%. Comparing base (a1b99f2) to head (14476e3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2756   +/-   ##
=======================================
  Coverage   82.46%   82.47%           
=======================================
  Files          42       42           
  Lines       35458    35459    +1     
  Branches    35458    35459    +1     
=======================================
+ Hits        29242    29245    +3     
+ Misses       2679     2678    -1     
+ Partials     3537     3536    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/procedure-empty-parameter-list branch from 69d3c27 to ea1bb64 Compare October 28, 2026 21:36
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/procedure-empty-parameter-list branch from ea1bb64 to 14476e3 Compare October 28, 2026 22:38

@s5dsn-eqee s5dsn-eqee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

Thanks @s5dsn-eqee for the review, I will be merging this PR now.

cc @alamb

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit c45d1f4 Oct 29, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change bug Something isn't working PostgreSQL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants