Skip to content

PostgreSQL: Support INHERITS in CREATE FOREIGN TABLE - #2752

Open
LucaCappelletti94 wants to merge 2 commits into
mainfrom
upstream/foreign-table-inherits
Open

LucaCappelletti94 wants to merge 2 commits into
mainfrom
upstream/foreign-table-inherits

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

CREATE FOREIGN TABLE child () INHERITS (parent) SERVER s, which pg_dump writes for an inherited foreign table, failed with Expected: SERVER, found: INHERITS. CreateForeignTable gains inherits, mirroring CreateTable.

https://www.postgresql.org/docs/current/sql-createforeigntable.html

@codecov-commenter

codecov-commenter commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.53%. Comparing base (b22bf61) to head (15cfdeb).

Files with missing lines Patch % Lines
src/ast/ddl.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2752   +/-   ##
=======================================
  Coverage   82.52%   82.53%           
=======================================
  Files          42       42           
  Lines       35533    35542    +9     
  Branches    35533    35542    +9     
=======================================
+ Hits        29323    29333   +10     
- Misses       2675     2676    +1     
+ Partials     3535     3533    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-inherits branch 3 times, most recently from c310f4d to c7991b3 Compare October 29, 2026 11:55
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-inherits branch from c7991b3 to 15cfdeb Compare October 29, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants