Repository navigation
PostgreSQL: Support ALTER TABLE ... RESET and storage parameters without a value - #2744
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2744 +/- ##
=======================================
Coverage 82.46% 82.47%
=======================================
Files 42 42
Lines 35458 35480 +22
Branches 35458 35480 +22
=======================================
+ Hits 29242 29263 +21
- Misses 2679 2681 +2
+ Partials 3537 3536 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
upstream/alter-table-reset-bare-reloptions
branch
4 times, most recently
from
October 28, 2026 21:36
9439ca4 to
8b0f1ad
Compare
LucaCappelletti94
force-pushed
the
upstream/alter-table-reset-bare-reloptions
branch
from
October 28, 2026 22:38
8b0f1ad to
b2477c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALTER TABLE t RESET (fillfactor)fails withExpected: ADD, RENAME, PARTITION, SWAP, DROP, REPLICA IDENTITY, SET, or SET TBLPROPERTIES after ALTER TABLE, found: RESET, and a storage parameter named without a value, as inCREATE VIEW v WITH (security_invoker) AS SELECT 1orALTER TABLE t SET (autovacuum_enabled), fails withExpected: =. PostgreSQL documentsRESET ( storage_parameter [, ... ] )forALTER TABLEand reads a storage parameter given without a value astrue.RESETparses into a newAlterTableOperation::ResetOptionsholding the parameter names, the shape #2730 uses forALTER VIEW ... RESET. A key with no=after it parses to the existingSqlOption::Identbehind a newDialect::supports_sql_option_without_value, which PostgreSQL and Generic enable, so the other dialects still report the missing=. PostgreSQL's grammar also accepts a bare key inCREATE TEXT SEARCHoptions, so the negative test there now runs on the dialects without the flag.