Snowflake: Add CREATE and DROP EXTERNAL VOLUME - #2397
Closed
sabir-akhadov-localstack wants to merge 1 commit into
Closed
Snowflake: Add CREATE and DROP EXTERNAL VOLUME#2397sabir-akhadov-localstack wants to merge 1 commit into
sabir-akhadov-localstack wants to merge 1 commit into
Conversation
sabir-akhadov-localstack
force-pushed
the
pr/05-external-volume
branch
from
July 2, 2026 14:52
621d03b to
1858c13
Compare
sabir-akhadov-localstack
marked this pull request as ready for review
July 3, 2026 15:41
Contributor
Author
|
Friendly ping on this one when someone has a moment. 🙂 It's been open since early July; CI is green and it's conflict-free against main. It follows the same structure as the recently merged CREATE WAREHOUSE support (#2388), so it should hopefully be a familiar review. Happy to rebase or adjust anything if needed. Thanks! |
Contributor
|
I suggest you split this into 4 PRs, one for macro type, so it is more likely to be digested a bit more quickly. |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sabir-akhadov-localstack
force-pushed
the
pr/05-external-volume
branch
from
September 1, 2026 08:56
44e059f to
f770b81
Compare
This was referenced Sep 1, 2026
Contributor
Author
|
Done, thanks for the suggestion! This PR is now scoped down to CREATE + DROP (mirroring the merged CREATE/DROP WAREHOUSE, #2388), and the rest is split out:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snowflake's external-volume DDL did not parse. Per the review suggestion this PR was split into four; this one now covers only
CREATE [OR REPLACE] EXTERNAL VOLUME [IF NOT EXISTS]andDROP EXTERNAL VOLUME(mirroring the merged CREATE/DROP WAREHOUSE, #2388). The follow-ups are ALTER (#2474), DESC (#2472) and SHOW (#2473).Example that failed before:
Each storage location is a parenthesized key-value option list parsed generically into the existing
KeyValueOptions, so fields (including the nestedENCRYPTION = (...)list) may appear in any order, matching real Snowflake. Only an empty location is rejected; semantic checks such as the requiredSTORAGE_BASE_URLor duplicate fields are left to the consumer, in line with the parser's permissive stance. The trailingALLOW_WRITESandCOMMENTproperties are accepted in either order.DROP EXTERNAL VOLUMEreuses the genericStatement::Dropvia a newObjectType::ExternalVolume. All statements round-trip.See the Snowflake
CREATE EXTERNAL VOLUMEdocs.