Skip to content

Fixed parsing OPTIONS(format = 'CSV') when creating external bigquery table #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romanoff wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

Fixed parsing OPTIONS(format = 'CSV') when creating external bigquery table #2268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/parser/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6297,6 +6297,8 @@ impl<'a> Parser<'a> {
let table_properties = self.parse_options(Keyword::TBLPROPERTIES)?;
let table_options = if !table_properties.is_empty() {
CreateTableOptions::TableProperties(table_properties)
} else if let Some(options) = self.maybe_parse_options(Keyword::OPTIONS)? {
CreateTableOptions::Options(options)
} else {
CreateTableOptions::None
};
Expand Down
10 changes: 10 additions & 0 deletions tests/sqlparser_bigquery.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,16 @@ fn parse_create_table_with_options() {
bigquery().verified_stmt(sql);
}

#[test]
fn parse_create_external_table_with_options() {
bigquery().verified_stmt(
"CREATE EXTERNAL TABLE dataset_id.table1 (hvr_tx_seq STRING) OPTIONS(format = 'CSV')",
);
bigquery().verified_stmt(
"CREATE EXTERNAL TABLE dataset_id.table1 (hvr_tx_seq STRING) OPTIONS(format = 'CSV', allow_quoted_newlines = true, encoding = 'UTF8')",
);
}

#[test]
fn parse_nested_data_types() {
let sql = "CREATE TABLE table (x STRUCT<a ARRAY<INT64>, b BYTES(42)>, y ARRAY<STRUCT<INT64>>)";
Expand Down