Adding support for PostgreSQL's STATISTICS CREATE, ALTER, DROP and COMMENT ON.#2257
Open
LucaCappelletti94 wants to merge 4 commits intoapache:mainfrom
Open
Adding support for PostgreSQL's STATISTICS CREATE, ALTER, DROP and COMMENT ON.#2257LucaCappelletti94 wants to merge 4 commits intoapache:mainfrom
STATISTICS CREATE, ALTER, DROP and COMMENT ON.#2257LucaCappelletti94 wants to merge 4 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds PostgreSQL-style support for
CREATE STATISTICS,ALTER STATISTICS,DROP STATISTICS, andCOMMENT ON STATISTICS(see docs: CREATE STATISTICS, ALTER STATISTICS, DROP STATISTICS, and COMMENT), with dedicated AST nodes (CreateStatistics,AlterStatistics, and related enums) plus parser integration in bothPostgreSqlDialectandGenericDialect.Since I am re-using
parse_table_and_joins, which accepts just about anything, I have added a validation function which verifies post hoc that it is actually correct syntax. I am not too happy with that solution, but it was either that or rewriting a variant ofparse_table_and_joins. Happy to hear suggestions.This is yet another PR stemming from differential fuzzing with postgres 18 - I have about other 2500 crash cases, does anybody want some?