PostgreSQL SQL/JSON Parser Support#2255
Open
LucaCappelletti94 wants to merge 3 commits intoapache:mainfrom
Open
PostgreSQL SQL/JSON Parser Support#2255LucaCappelletti94 wants to merge 3 commits intoapache:mainfrom
LucaCappelletti94 wants to merge 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds PostgreSQL SQL/JSON parsing coverage for
JSON_EXISTS,JSON_VALUE,JSON_QUERY, and table-levelJSON_TABLE ... ON ERROR, following the PostgreSQL SQL/JSON query-function and JSON_TABLE syntax documented in the official manuals (SQL/JSON query functions, JSON_TABLE). Implementation-wise, the parser now uses function-aware clause parsing (instead of globally accepting these clauses in all function calls), introduces explicit AST clause variants forPASSING,ON EMPTY/ON ERROR, wrapper/quote behavior, andFORMAT JSON, and extendsTableFactor::JsonTablewith an optional table-level error-handling field.This keeps round-trip formatting deterministic, and avoids broad dialect side effects. I left
IS JSONexprs outside of this PR for now.If anybody's wondering where all of these PRs are coming from, I am running differential fuzzing against sqlparser vs postgres 18. It's a bit of a blood bath.