Adding support for PostgreSQL's SUBSCRIPTION (CREATE, ALTER, DROP, COMMENT)#2254
Open
LucaCappelletti94 wants to merge 2 commits intoapache:mainfrom
Open
Adding support for PostgreSQL's SUBSCRIPTION (CREATE, ALTER, DROP, COMMENT)#2254LucaCappelletti94 wants to merge 2 commits intoapache:mainfrom
PostgreSQL's SUBSCRIPTION (CREATE, ALTER, DROP, COMMENT)#2254LucaCappelletti94 wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds PostgreSQL parsing support for subscription statements (
CREATE SUBSCRIPTION,ALTER SUBSCRIPTION,DROP SUBSCRIPTION, andCOMMENT ON SUBSCRIPTION) according to the upstream syntax documented inCREATE SUBSCRIPTION,ALTER SUBSCRIPTION,DROP SUBSCRIPTION, andCOMMENT, and it also aligns privilege parsing with PostgreSQL role-style grant/revoke usage fromGRANTandREVOKE: implementation-wise, the parser now uses dedicated subscription AST nodes/operations, enforces subscription names as single identifiers (matching PostgreSQL object naming behavior for subscriptions), handles predefined PostgreSQL roles inGRANT/REVOKEvia a PostgreSQL-onlypg_*path instead of a broad privilege fallback (to preserve typo detection for regular privilege keywords), and gatesRESET SESSION AUTHORIZATIONto PostgreSQL semantics as described inRESET.If anybody's wondering where all of these PRs are coming from, I am running differential fuzzing against sqlparser vs postgres 18. It's a bit of a blood bath. Maybe we should have at least a unit test running against postgres's regression statements?