Adding support for TABLESPACE#2253
Open
LucaCappelletti94 wants to merge 2 commits intoapache:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds cross-dialect
TABLESPACEsupport by implementing PostgreSQL forms (CREATE/ALTER/DROP TABLESPACE) and MySQL forms (CREATE/ALTER/DROP [UNDO] TABLESPACE) with Generic dialect handling both syntaxes as a union parser, using explicit AST modeling instead of loose keyword parsing:CreateTablespacenow carries dialect-specific definitions, MySQLALTER TABLESPACEis represented as an ordered list of options to preserve multi-clause statements, andDROP TABLESPACEhas a dedicated statement type to avoid over-accepting genericDROPbehaviors and to keep dialect rules explicit (for example, PostgreSQLIF EXISTSvs MySQL-specific clauses)Syntax and behavior were aligned against the official documentation for PostgreSQL CREATE TABLESPACE, PostgreSQL ALTER TABLESPACE, PostgreSQL DROP TABLESPACE, MySQL CREATE TABLESPACE, MySQL ALTER TABLESPACE, and MySQL DROP TABLESPACE, with coverage added in both MySQL and PostgreSQL parser tests.
If anybody's wondering where all of these PRs are coming from, I am running differential fuzzing against sqlparser vs postgres 18. It's a bit of a blood bath.