Add PostgreSQL Collation DDL Support#2249
Open
LucaCappelletti94 wants to merge 3 commits intoapache:mainfrom
Open
Add PostgreSQL Collation DDL Support#2249LucaCappelletti94 wants to merge 3 commits intoapache:mainfrom
LucaCappelletti94 wants to merge 3 commits intoapache:mainfrom
Conversation
Add AST support for PostgreSQL collation statements and related object kinds.\n\n- introduce CreateCollation and AlterCollation structures\n- add CreateCollationDefinition and AlterCollationOperation enums\n- extend Statement with CreateCollation/AlterCollation variants\n- add ObjectType::Collation and CommentObject::Collation\n- wire display/from conversions and span matching hooks
Extend parser dispatch and handlers for PostgreSQL collation syntax.\n\n- parse CREATE COLLATION with FROM and option-list forms\n- parse ALTER COLLATION operations: RENAME TO, OWNER TO, SET SCHEMA, REFRESH VERSION\n- accept DROP COLLATION via generic DROP statement path\n- support COMMENT ON COLLATION targets
Add parser tests for PostgreSQL collation statements and comment targets.\n\n- validate AST shape for CREATE/ALTER COLLATION variants\n- validate DROP COLLATION and COMMENT ON COLLATION AST mapping\n- round-trip the full statement set used for regression investigation\n- include COLLATION in shared COMMENT object-type coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds parser and AST support for PostgreSQL collation DDL statements that were previously missing:
The implementation is aligned with PostgreSQL syntax from official docs, including ALTER COLLATION ... REFRESH VERSION.
References