Include DML keyword in statement span #2090
Open
+127
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xitep
force-pushed
the
main
branch
4 times, most recently
from
42aba2d to
bfc8770
Compare
iffyio
reviewed
Nov 11, 2025
Comment on lines
+5143
to
+5146
| insert_token: AttachedToken(TokenWithSpan { | ||
| token: Token::make_keyword("INSERT"), | ||
| span: Span::new((1, 1).into(), (1, 7).into()), | ||
| }), |
Contributor
There was a problem hiding this comment.
Suggested change
| insert_token: AttachedToken(TokenWithSpan { | |
| token: Token::make_keyword("INSERT"), | |
| span: Span::new((1, 1).into(), (1, 7).into()), | |
| }), | |
| insert_token: AttachedToken::empty(), |
I think for these we can use an empty token - since token comparisons are ignored in tests. Same for the other files
| } | ||
|
|
||
| #[test] | ||
| fn test_update_statement_span() { |
Contributor
There was a problem hiding this comment.
Can we add similar test for DELETE, INSERT, REPLACE statements?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the "update" keyword itself in the corresponding statement, making the statement's span cover its parsed source code
Motivation: party a (SQL) re-formatter and party the need to extract possible comments preceding the statements (and/or right after the keyword)
Related: [EPIC] Complete Span (source location) information / feature #1548