test: cover string expression routing and native opt-in - #5915
Merged
Merged
Conversation
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 14, 2026
sunchao
approved these changes
Sep 14, 2026
Contributor
Author
|
Thanks for the review @sunchao and @andygrove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4616.
Rationale for this change
Result comparisons alone can pass through the wrong execution path. These tests check string expression routing when JVM dispatch is enabled or disabled and when native execution is explicitly opted into.
What changes are included in this PR?
Add SQL fixtures that assert native, JVM dispatcher and Spark fallback paths for LIKE, concat, concat_ws, translate, base64 decoding, upper, lower, initcap, replace and get_json_object. Compare results against Spark, including null and empty inputs.
How are these changes tested?
All 11 fixtures pass together on Spark 4.1.3 after applying the change to current main. The original groups passed fork CI on Spark 3.4, 3.5, 4.0, 4.1 and 4.2 (string routing, native opt-in). Apache RAT passed.