Skip to content

test: cover string expression routing and native opt-in - #5915

Merged
sunchao merged 1 commit into
apache:mainfrom
rich7420:test/4616-string-routing
Sep 15, 2026
Merged

sunchao merged 1 commit into
apache:mainfrom
rich7420:test/4616-string-routing

Conversation

@rich7420

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Part of #4616.

Rationale for this change

Result comparisons alone can pass through the wrong execution path. These tests check string expression routing when JVM dispatch is enabled or disabled and when native execution is explicitly opted into.

What changes are included in this PR?

Add SQL fixtures that assert native, JVM dispatcher and Spark fallback paths for LIKE, concat, concat_ws, translate, base64 decoding, upper, lower, initcap, replace and get_json_object. Compare results against Spark, including null and empty inputs.

How are these changes tested?

All 11 fixtures pass together on Spark 4.1.3 after applying the change to current main. The original groups passed fork CI on Spark 3.4, 3.5, 4.0, 4.1 and 4.2 (string routing, native opt-in). Apache RAT passed.

@github-actions github-actions Bot added enhancement New feature or request test Testing related labels Sep 14, 2026

@andygrove andygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice. Thanks @rich7420

@andygrove
andygrove added this pull request to the merge queue Sep 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 14, 2026
@sunchao
sunchao added this pull request to the merge queue Sep 14, 2026
Merged via the queue into apache:main with commit 39da850 Sep 15, 2026
52 checks passed
@rich7420

Copy link
Copy Markdown
Contributor Author

Thanks for the review @sunchao and @andygrove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request test Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants