perf: optimize spark_regexp_extract#4894
Merged
andygrove merged 2 commits intoJul 16, 2026
Merged
Conversation
andygrove
marked this pull request as ready for review
July 11, 2026 13:52
andygrove
changed the title
spark_regexp_extract
comphead
reviewed
Jul 11, 2026
| // Reuse a single set of capture locations across every row. `Regex::captures` | ||
| // allocates a fresh location buffer on each call; `captures_read` fills this | ||
| // preallocated buffer in place, so the per-row heap allocation is paid only once. | ||
| let mut locations = regex.capture_locations(); |
Contributor
There was a problem hiding this comment.
prob we can reuse OptimizedRegex ?
mbutrovich
approved these changes
Jul 15, 2026
mbutrovich
left a comment
mbutrovich
left a comment
Contributor
There was a problem hiding this comment.
This one LGTM, thanks @andygrove!
…et-20260711-073621
andygrove
deleted the
auto-opt/spark_regexp_extract-datafusion-comet-20260711-073621
branch
July 16, 2026 21:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Optimize existing expression.
What changes are included in this PR?
Reuse a single CaptureLocations across all rows via captures_read instead of allocating a fresh capture buffer per row with captures(), eliminating one heap allocation per row in the regexp_extract array path.
How are these changes tested?
Existing tests
Benchmark (criterion):