fix: make ToJson PartialEq<dyn Any> consistent with PartialEq#4446
Merged
Conversation
Member
|
Thanks @0lai0 . Could you fix linter errors? |
andygrove
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4430
Rationale for this change
PartialEq<dyn Any>is the path DataFusion uses to compareArc<dyn PhysicalExpr>values in the physical planner. The previous impl only comparedexprandtimezone, so twoToJsonexpressions that differed only inignore_null_fields(or historically,timezone) would compare equal through that path, risking incorrect deduplication or caching.What changes are included in this PR?
Delegate
PartialEq<dyn Any>toself == other, which calls the regularPartialEqimpl and ensures both paths always compare the same fields.How are these changes tested?
Three new unit tests in
json_funcs::to_json::test:test_partial_eq_sameidentical exprs are equal via both pathstest_partial_eq_dyn_any_differs_on_timezonedifferenttimezoneis not equal viadyn Anytest_partial_eq_dyn_any_differs_on_ignore_null_fieldsdifferentignore_null_fieldsis not equal viadyn Any