Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/pr_build_linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,7 @@ jobs:
org.apache.spark.sql.comet.CometDppFallbackRepro3949Suite
org.apache.spark.sql.comet.CometShuffleFallbackStickinessSuite
org.apache.spark.sql.comet.CometDecimalArithmeticViewSuite
org.apache.spark.sql.comet.util.UtilsSuite
org.apache.comet.objectstore.NativeConfigSuite
org.apache.spark.sql.CometToPrettyStringSuite
org.apache.spark.sql.CometCollationSuite
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ object Utils extends CometTypeShim with Logging {

val (fieldVectors, batchProviderOpt) = getBatchFieldVectors(batch)
val root = new VectorSchemaRoot(fieldVectors.asJava)
root.setRowCount(batch.numRows())
val provider = batchProviderOpt.getOrElse(dictionaryProvider)

val writer = new ArrowStreamWriter(root, provider, Channels.newChannel(out))
Expand Down Expand Up @@ -336,6 +337,8 @@ object Utils extends CometTypeShim with Logging {
return (Array.empty, 0L, 0L)
}

targetRoot.setRowCount(totalRows.toInt)

assert(
targetRoot.getRowCount.toLong == totalRows,
s"Row count mismatch after coalesce: ${targetRoot.getRowCount} != $totalRows")
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

package org.apache.spark.sql.comet.util

import org.apache.spark.sql.CometTestBase
import org.apache.spark.sql.vectorized.{ColumnarBatch, ColumnVector}

class UtilsSuite extends CometTestBase {

test("serializeBatches preserves row count for a zero-column batch") {
val numRows = 5
val batch = new ColumnarBatch(Array.empty[ColumnVector], numRows)

val (rowCount, buf) = Utils.serializeBatches(Iterator(batch)).next()
assert(rowCount == numRows)

val decoded = Utils.decodeBatches(buf, "test").toSeq
assert(decoded.map(_.numRows()).sum == numRows)
}

test("coalesceBroadcastBatches preserves row count across zero-column inputs") {
val numRows = 5
val numBatches = 3
val batches =
(0 until numBatches).map(_ => new ColumnarBatch(Array.empty[ColumnVector], numRows))

val bufs = Utils.serializeBatches(batches.iterator).map(_._2).toSeq.iterator
val (coalesced, batchCount, totalRows) = Utils.coalesceBroadcastBatches(bufs)

val expected = numRows.toLong * numBatches
assert(batchCount == numBatches)
assert(totalRows == expected)

val decoded = coalesced.iterator.flatMap(b => Utils.decodeBatches(b, "test")).toSeq
assert(decoded.map(_.numRows()).sum == expected)
}
}
Loading