-
Notifications
You must be signed in to change notification settings - Fork 323
chore(audit): audit any_value and expand tests #4438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andygrove
wants to merge
1
commit into
apache:main
Choose a base branch
from
andygrove:autonomous-audit/any_value
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
104 changes: 104 additions & 0 deletions
104
spark/src/test/resources/sql-tests/expressions/aggregate/any_value.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| -- Licensed to the Apache Software Foundation (ASF) under one | ||
| -- or more contributor license agreements. See the NOTICE file | ||
| -- distributed with this work for additional information | ||
| -- regarding copyright ownership. The ASF licenses this file | ||
| -- to you under the Apache License, Version 2.0 (the | ||
| -- "License"); you may not use this file except in compliance | ||
| -- with the License. You may obtain a copy of the License at | ||
| -- | ||
| -- http://www.apache.org/licenses/LICENSE-2.0 | ||
| -- | ||
| -- Unless required by applicable law or agreed to in writing, | ||
| -- software distributed under the License is distributed on an | ||
| -- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| -- KIND, either express or implied. See the License for the | ||
| -- specific language governing permissions and limitations | ||
| -- under the License. | ||
|
|
||
| -- any_value is a RuntimeReplaceableAggregate that Spark's optimizer rewrites | ||
| -- to first(expr, ignoreNulls) before physical planning, so these tests exercise | ||
| -- the same Comet path as first_last.sql but pin the any_value name explicitly. | ||
|
|
||
| -- ============================================================ | ||
| -- Setup: shared tables | ||
| -- ============================================================ | ||
|
|
||
| statement | ||
| CREATE TABLE test_any_value(i int, grp string) USING parquet | ||
|
|
||
| statement | ||
| INSERT INTO test_any_value VALUES (1, 'a'), (2, 'a'), (3, 'a'), (NULL, 'b'), (4, 'b') | ||
|
|
||
| statement | ||
| CREATE TABLE test_any_value_ignore_nulls(id int, val int, grp string) USING parquet | ||
|
|
||
| statement | ||
| INSERT INTO test_any_value_ignore_nulls VALUES | ||
| (1, NULL, 'a'), | ||
| (2, 10, 'a'), | ||
| (3, 20, 'a'), | ||
| (4, NULL, 'b'), | ||
| (5, 30, 'b'), | ||
| (6, NULL, 'b') | ||
|
|
||
| statement | ||
| CREATE TABLE test_any_value_all_nulls(val int, grp string) USING parquet | ||
|
|
||
| statement | ||
| INSERT INTO test_any_value_all_nulls VALUES (NULL, 'a'), (NULL, 'a'), (NULL, 'b'), (1, 'b') | ||
|
|
||
| -- ============================================================ | ||
| -- any_value: basic (default behavior includes nulls) | ||
| -- ============================================================ | ||
|
|
||
| query | ||
| SELECT any_value(i) FROM test_any_value | ||
|
|
||
| query | ||
| SELECT grp, any_value(i) FROM test_any_value GROUP BY grp ORDER BY grp | ||
|
|
||
| -- ============================================================ | ||
| -- any_value with isIgnoreNull literal | ||
| -- ============================================================ | ||
|
|
||
| -- any_value(expr, true) ignores nulls. | ||
| query | ||
| SELECT any_value(val, true) FROM test_any_value_ignore_nulls | ||
|
|
||
| query | ||
| SELECT grp, any_value(val, true) FROM test_any_value_ignore_nulls GROUP BY grp ORDER BY grp | ||
|
|
||
| -- any_value(expr, false) respects nulls (default). | ||
| query | ||
| SELECT grp, any_value(val, false) FROM test_any_value_ignore_nulls GROUP BY grp ORDER BY grp | ||
|
|
||
| -- ============================================================ | ||
| -- any_value: all-null group with ignoreNulls | ||
| -- ============================================================ | ||
|
|
||
| -- Group 'a' has all nulls so result is NULL even when ignoring nulls. | ||
| query | ||
| SELECT grp, any_value(val, true) FROM test_any_value_all_nulls GROUP BY grp ORDER BY grp | ||
|
|
||
| -- ============================================================ | ||
| -- any_value alongside other aggregates | ||
| -- ============================================================ | ||
|
|
||
| query | ||
| SELECT grp, | ||
| any_value(val, true), | ||
| count(val), | ||
| sum(val) | ||
| FROM test_any_value_ignore_nulls GROUP BY grp ORDER BY grp | ||
|
|
||
| -- ============================================================ | ||
| -- any_value matches first when called identically | ||
| -- ============================================================ | ||
|
|
||
| -- Same input expression and same ignoreNulls flag should yield identical results | ||
| -- because Spark rewrites any_value(x, b) to first(x, b). | ||
| query | ||
| SELECT | ||
| any_value(val, true) = first(val, true) AS ignore_nulls_match, | ||
| any_value(val, false) = first(val, false) AS respect_nulls_match | ||
| FROM test_any_value_ignore_nulls | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if its first/last, should it be used with GROUP BY ?