fix: parameterize file count in Native_datafusion metrics test#3896
Merged
comphead merged 1 commit intoapache:mainfrom Apr 3, 2026
Merged
fix: parameterize file count in Native_datafusion metrics test#3896comphead merged 1 commit intoapache:mainfrom
comphead merged 1 commit intoapache:mainfrom
Conversation
comphead
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up to PR #3798 (Fixes Issue #3791).
Rationale for this change
This addresses the post-merge review comments from @comphead in PR #3798 regarding the removal of hardcoded literals in the newly added test for
CometNativeScanExecmetrics.What changes are included in this PR?
2into a well-namedval inputFiles = 2constant inside the test"Native_datafusion reports correct files and bytes scanned".repartition()logic to strictly rely oninputFilesfor better readability and maintainability.How are these changes tested?
Verified locally by running
CometExecSuite.