fix: Iceberg reflection for current() on TableOperations hierarchy#3895
Open
karuppayya wants to merge 2 commits intoapache:mainfrom
Open
fix: Iceberg reflection for current() on TableOperations hierarchy#3895karuppayya wants to merge 2 commits intoapache:mainfrom
karuppayya wants to merge 2 commits intoapache:mainfrom
Conversation
mbutrovich
changed the title
Use findMethodInHierarchy instead of getDeclaredMethod so getTableMetadata and format-version reflection work when current() is declared on a superclass (e.g. BaseMetastoreTableOperations for Hive/Glue-style ops). Add IcebergReflectionSuite with a BaseMetastoreTableOperations stub and BaseTable. Made-with: Cursor
karuppayya
force-pushed
the
fix-mehthod-hierarchy
branch
from
27dac8c to
433832e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3894.
Rationale for this change
Fix
NoSuchMethodExceptionfrom Iceberg ReflectionWhat changes are included in this PR?
Use
findMethodInHierarchyinstead ofgetDeclaredMethodso getTableMetadata and format-version reflection work whencurrent()is declared on a superclass (e.g. BaseMetastoreTableOperations for Hive/Glue-style ops).How are these changes tested?