test: improve array_distinct test coverage and incompatibility description#3887
Open
andygrove wants to merge 1 commit intoapache:mainfrom
Open
test: improve array_distinct test coverage and incompatibility description#3887andygrove wants to merge 1 commit intoapache:mainfrom
andygrove wants to merge 1 commit intoapache:mainfrom
Conversation
…ption Expand SQL file tests for array_distinct from 2 queries on array<int> to comprehensive coverage across int, bigint, string, boolean, double, float, decimal, and nested array types. Add edge case coverage for NULL handling, NaN/Infinity deduplication, boundary values, and negative zero. Add descriptive reason to the Incompatible support level so users understand that output elements are sorted rather than preserving insertion order.
kazuyukitanimura
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3174.
Rationale for this change
The existing
array_distinctSQL file tests only coveredarray<int>with 2 queries. TheIncompatiblesupport level had no description, making it unclear to users why the expression is marked incompatible.What changes are included in this PR?
Expanded SQL file tests for
array_distinctfrom 2 queries to comprehensive coverage across 7 element types:array<array<int>>with duplicates and NULLsAdded descriptive reason to
Incompatiblesupport level:"Output elements are sorted rather than preserving insertion order".How are these changes tested?
All new tests are SQL file tests that run via
CometSqlFileTestSuitewith theConfigMatrixfor both dictionary-encoded and plain parquet. Tests usespark_answer_onlymode since the expression isIncompatible(DataFusion sorts output elements while Spark preserves insertion order). Verified passing locally with both dictionary configurations.