Feat: to_json Infinity/-Infinity Nan values support#3875
Open
kazantsev-maksim wants to merge 36 commits intoapache:mainfrom
Open
Feat: to_json Infinity/-Infinity Nan values support#3875kazantsev-maksim wants to merge 36 commits intoapache:mainfrom
kazantsev-maksim wants to merge 36 commits intoapache:mainfrom
Conversation
This reverts commit 768b3e9.
Contributor
|
I think we need add new tests for +/- inf and NaN |
andygrove
reviewed
Apr 2, 2026
andygrove
reviewed
Apr 2, 2026
andygrove
reviewed
Apr 2, 2026
Contributor
Author
|
Test failed because since Spark 4.0.0 to_json use runtime expression replacement: https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala#L418 |
added 2 commits
April 3, 2026 21:34
Contributor
Author
|
I marked sql-tests as ignored until to_json will not support Spark 4.0.0. CC @andygrove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3016
Rationale for this change
What changes are included in this PR?
How are these changes tested?
Tested with existing unit tests