Put a max length on the Fiql search term and fix performance parsing … - #3443
Open
coheigea wants to merge 1 commit into
Open
Put a max length on the Fiql search term and fix performance parsing …#3443coheigea wants to merge 1 commit into
coheigea wants to merge 1 commit into
Conversation
coheigea
force-pushed
the
coheigea/fiql-max-length
branch
from
September 4, 2026 14:44
a896745 to
b6dff9f
Compare
reta
reviewed
Sep 4, 2026
| throw new SearchParseException("Not a comparison expression: " + expr); | ||
| } | ||
|
|
||
| private int[] findComparator(String expr) { |
Member
There was a problem hiding this comment.
@coheigea I do understand the intent here, but does it actually make sense to go such far (basically rewriting what regex is doing)? We've limited the expression length, I think the issue should be largely mitigated, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…issue