Validate redirect URIs according to OpenID Connect Dynamic Client Registration 1.0 specification#3318
Open
reta wants to merge 3 commits into
Open
Validate redirect URIs according to OpenID Connect Dynamic Client Registration 1.0 specification#3318reta wants to merge 3 commits into
reta wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds redirect URI validation in DynamicRegistrationService intended to align dynamic client registration with the OpenID Connect Dynamic Client Registration 1.0 redirect URI rules, and extends the unit tests to cover newly enforced behaviors.
Changes:
- Implement redirect URI parsing and validation in
DynamicRegistrationService#validateRequestUri. - Introduce application-type constants (
web/native) and loopback host allowlist handling. - Add unit tests covering acceptance/rejection of various redirect URI patterns.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/services/DynamicRegistrationService.java | Adds redirect URI validation logic and new constants to enforce OIDC-aligned constraints. |
| rt/rs/security/oauth-parent/oauth2/src/test/java/org/apache/cxf/rs/security/oauth2/services/DynamicRegistrationServiceTest.java | Adds tests for allowed/rejected redirect URIs across web/native client types and grant types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…istration 1.0 specification
reta
force-pushed
the
validate/redirect.uris
branch
from
July 19, 2026 16:18
b105423 to
71060f2
Compare
Member
Author
|
@coheigea please let me know if it looks good to you, thanks! |
coheigea
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate redirect URIs according to OpenID Connect Dynamic Client Registration 1.0 specification