Fix Error on inverted range for _all_docs#5956
Open
yaxit24 wants to merge 1 commit intoapache:mainfrom
Open
Conversation
When a _view request has an impossible start_key/end_key combination, CouchDB returns a 400 Bad Request with query_parse_error. This adds the same validation to _all_docs. Uses check_range function in couch_mrview_util. Added tests spanning both the HTTP API clustered path and direct Erlang MRView API.
yaxit24
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
If a _view has an impossible start_key/end_key combination, CouchDB returns a helpful 400 query_parse_error. However, _all_docs lacked this validation and would silently return 200 with an empty result set {"rows":[]}.
Testing recommendations
You can verify this locally using curl:
Before this PR (returns 200 with empty rows): curl -X GET "http://127.0.0.1:5984/mydb/_all_docs?startkey=\"z\"&endkey=\"a\""
After this PR (returns 400): curl -X GET "http://127.0.0.1:5984/mydb/_all_docs?startkey=\"z\"&endkey=\"a\""
Related Issues or Pull Requests
issue #5866
Checklist
rel/overlay/etc/default.inisrc/docsfolder