Skip to content

Fix TypeError in nouveau for stored index types #5952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vamsi2246 wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

Fix TypeError in nouveau for stored index types #5952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90a2059
Fix TypeError in nouveau for stored index types
Mar 29, 2026
1d80257
Merge branch 'main' into fix-nouveau-typeerror
vamsi2246 Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion share/server/nouveau.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ var Nouveau = (function () {
case 'stored':
var value = arguments[2];
if (typeof value != 'number' && typeof value != 'string') {
throw ({ name: 'TypeError', message: 'type of ' + value + ' must be a string or number' });
throw ({ name: 'TypeError', message: 'type of value must be a string or number not ' + typeof value });
Copy link
Copy Markdown
Member

@rnewson rnewson Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I think we should include name in this string too, so that an error reads type of 'foo' must be a string or number not object for example. so name where value previous was but keep the typeof value at the end?

}
index_results.push({
'@type': type,
Expand Down