Skip to content

chore(addBuildPhase): remove unused variable buildPhaseSection#175

Open
erisu wants to merge 1 commit into
apache:masterfrom
erisu:chore/remove-unused-code
Open

chore(addBuildPhase): remove unused variable buildPhaseSection#175
erisu wants to merge 1 commit into
apache:masterfrom
erisu:chore/remove-unused-code

Conversation

@erisu

@erisu erisu commented Jun 25, 2026

Copy link
Copy Markdown
Member

Remove unused variable buildPhaseSection in the addBuildPhase.

This variable appears to have been left behind during the refactoring in this commit, prior to this code base being contributed: alunny/node-xcode@8b3c7f6

The current implementation still appears to preserve the original logic:

if (!this.hash.project.objects[buildPhaseType]) {
    this.hash.project.objects[buildPhaseType] = {};
}

if (!this.hash.project.objects[buildPhaseType][buildPhaseUuid]) {
    this.hash.project.objects[buildPhaseType][buildPhaseUuid] = buildPhase;
    this.hash.project.objects[buildPhaseType][commentKey] = comment;
}

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.36%. Comparing base (81ddc4a) to head (329bd0b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   97.34%   97.36%   +0.02%     
==========================================
  Files          51       51              
  Lines       11058    11052       -6     
==========================================
- Hits        10764    10761       -3     
+ Misses        294      291       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants