chore(addBuildPhase): remove unused variable buildPhaseSection#175
Open
erisu wants to merge 1 commit into
Open
chore(addBuildPhase): remove unused variable buildPhaseSection#175erisu wants to merge 1 commit into
erisu wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 97.34% 97.36% +0.02%
==========================================
Files 51 51
Lines 11058 11052 -6
==========================================
- Hits 10764 10761 -3
+ Misses 294 291 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused variable
buildPhaseSectionin theaddBuildPhase.This variable appears to have been left behind during the refactoring in this commit, prior to this code base being contributed: alunny/node-xcode@8b3c7f6
The current implementation still appears to preserve the original logic: