fix(addBuildPhase): adding of PBXBuildFile entries to lookup table#174
Merged
erisu merged 2 commits intoJun 25, 2026
Merged
Conversation
- Add PBXBuildFile entry to filePathToBuildFile lookup table when a valid identifier is present. - Valid identifier is determined when the fileReference has either a path or name property value. - The path property takes priority when both path and name are defined. - When the path and name properties are not defined the entry is not added to the lookup table.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 97.31% 97.34% +0.02%
==========================================
Files 51 51
Lines 10968 11058 +90
==========================================
+ Hits 10674 10764 +90
Misses 294 294 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
breautek
approved these changes
Jun 24, 2026
dpogue
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PBXBuildFileentry tofilePathToBuildFilelookup table when a valid identifier is present.fileReferencehas either apathornameproperty value.pathproperty takes priority when bothpathandnameare defined.pathandnameproperties are not defined the entry is not added to the lookup table.Additionally, this PR
Any additional JSDoc changes I would like to keep under #171. This PR only added the minimum required to document
addBuildPhase.The main purpose of this PR is to resolve and close PR #140.
Closes #140
PR #140 was attempting to resolve a failure that occurred when looping through build files to create the
filePathToBuildFilelookup table, where a file reference did not havepathdefined. The PR attempted to resolve this by skipping when thepathproperty of the file reference was missing.There are cases where
namecan be used instead ofpath. In those cases,nameappears to serve as the file path, with path resolution determined by the file reference'ssourceTree. But generally,nameoften matches the file name.Same issue was reported here: apache/cordova-ios#1357
This PR takes a different approach and check if either
pathornameis defined before it skipped the build file.