Fix ArrayUtils.reverse range underflow on Integer.MIN_VALUE end#1750
Merged
Conversation
Member
|
Good find @alhudz, merged 🚀 Do you see any other similar index issue in this class? |
garydgregory
added a commit
that referenced
this pull request
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:
ArrayUtils.reverse(new int[]{1, 2, 3}, 0, Integer.MIN_VALUE).Expected: no change, since the
endIndexExclusiveJavadoc documents an undervalue< start indexas no change.Actual:
ArrayIndexOutOfBoundsException: Index 2147483647 out of bounds for length 3.Cause:
Math.min(array.length, endIndexExclusive) - 1keepsInteger.MIN_VALUEand the- 1underflows toInteger.MAX_VALUE, so thewhile (j > i)loop indexes past the array. All nine primitive andObjectrange overloads share the line.Fix: clamp the end to zero before the decrement with the existing
max0helper, as the siblingsubarrayandshiftmethods already do. Every other negative end was already a no-op, so valid ranges are unchanged.