Skip to content

NumberUtils.isCreatable(String) should match NumberUtils.createNumber(String), exactly#1626

Merged
garydgregory merged 20 commits intoapache:masterfrom
garydgregory:bugfix/NumberUtils.isCreatable_simple
Apr 16, 2026
Merged

NumberUtils.isCreatable(String) should match NumberUtils.createNumber(String), exactly#1626
garydgregory merged 20 commits intoapache:masterfrom
garydgregory:bugfix/NumberUtils.isCreatable_simple

Conversation

@garydgregory
Copy link
Copy Markdown
Member

NumberUtils.isCreatable(String) should match NumberUtils.createNumber(String), exactly

Add tests from PR #1623

  • Read the contribution guidelines for this project.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

@garydgregory garydgregory changed the title Bugfix/number utils.is creatable simple NumberUtils.isCreatable(String) should match NumberUtils.createNumber(String), exactly Apr 15, 2026
@chtompki
Copy link
Copy Markdown
Member

chtompki commented Apr 16, 2026

Looks good to me

@garydgregory garydgregory merged commit 127050d into apache:master Apr 16, 2026
35 of 36 checks passed
@garydgregory garydgregory deleted the bugfix/NumberUtils.isCreatable_simple branch April 16, 2026 13:29
garydgregory added a commit that referenced this pull request Apr 16, 2026
NumberUtils.createNumber(String), exactly #1626.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants