Conversation
PnmImageParser accepts PBM, PGM, PPM, PNM and PAM, but Imaging.writeImage passed null parameters, so every request took the default writer (PPM, or PAM for a transparent image). The format now reaches the parser through a writeImageForFormat hook that the base class ignores and PnmImageParser overrides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imaging.writeImagewithImageFormats.PBM,PGMorPAMwrites a P6 PPM.PnmImageParseraccepts all five PNM formats, butImagingpassed null parameters, so it always used the default writer. The format reached the parser asPARAM_KEY_FORMATuntil IMAGING-159 (406f140, 1.0-alpha3) removed the parameter overloads.Imaging.writeImagenow calls a protectedwriteImageForFormathook onAbstractImageParser; the base delegates towriteImage(src, os, null)andPnmImageParseroverrides it to set the subtype. PNM keeps the transparency based default. Behaviour change: a transparent image requested as PBM, PGM or PPM now gets that format without its alpha instead of falling through to PAM.The test fails on master with
PBM ==> expected: <P4> but was: <P6>; the default Maven goal passes with 1260 tests.mvn; that'smvnon the command line by itself.