Resolve column name in ResultSetIterator.set#426
Open
rootvector2 wants to merge 1 commit into
Open
Conversation
the read path resolves the dyna-property name to the real column name via getColumnName, but set passed the raw name to updateObject, so with the default lowerCase a mixed-case column update targeted the wrong column.
garydgregory
requested changes
Jul 22, 2026
garydgregory
left a comment
Member
There was a problem hiding this comment.
Hi @rootvector2
Please see my comment.
| */ | ||
| @Test | ||
| void testSetUsesColumnName() throws Exception { | ||
| final String[] updatedColumn = new String[1]; |
Member
There was a problem hiding this comment.
@rootvector2
Use an AtomicReference instead of the old-school array hack ;)
Member
|
@rootvector2 Ping 🔔 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setpasses the raw lower-cased property name toResultSet.updateObjectwhile the read path resolves it throughgetColumnNamefirst, so under the defaultlowerCasean update to a mixed-case column targets the wrong column or throws on a case-sensitive driver; found diffing the get and set paths againstgetObject.mvn; that'smvnon the command line by itself.