Make WrapDynaClass instance cache thread-safe#418
Merged
garydgregory merged 2 commits intoJul 15, 2026
Conversation
garydgregory
requested changes
Jul 14, 2026
garydgregory
left a comment
Member
There was a problem hiding this comment.
@rootvector2
Please add a unit test to avoid a future regression.
Signed-off-by: Naveed Khan <dxbnaveed.k@gmail.com>
Contributor
Author
|
added a regression test that races 16 threads on |
Member
|
Merged, TY @rootvector2 , please port to 1.X if possible. |
garydgregory
added a commit
that referenced
this pull request
Jul 15, 2026
7 tasks
Contributor
Author
|
thanks for merging. port is up in #419 — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WrapDynaClass.createDynaClasspopulates its per-classloader cache withcomputeIfAbsent, but the cache is a plainWeakHashMap, so threads that share a context classloader race on an unsynchronized map wherecomputeIfAbsentis not atomic: concurrent callers can build and return differentWrapDynaClassinstances for one key, and the structural writes can corrupt the map. Switch the cache toBeanUtils.createCache(), the weak-keyedConcurrentReferenceHashMapthatMethodUtils,ConvertUtilsBeanandPropertyUtilsBeanalready use. Found while auditing the package'scomputeIfAbsentcall sites against those thread-safe caches. Like theMethodUtilsvisibility fix this race has no deterministic unit test so none is added, though a stress loop over concurrentcreateDynaClasscalls does surface the duplicate instances.mvn; that'smvnon the command line by itself.