Make AgentConnectTaskPool core and max pool sizes configurable via global config by nvazquez · Pull Request #13552 · apache/cloudstack

nvazquez · 2026-07-06T17:15:27Z

Description

This PR replaces the hardcoded values of 100/500 in initConnectExecutor() with ConfigKeys:

agent.connect.executor.core.pool.size (default 100) and
agent.connect.executor.max.pool.size (default 500)

In case the pool size > max pool size, the default values 100/500 will be used to prevent exceptions on startup

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

nvazquez · 2026-07-06T17:17:58Z

@blueorangutan package

blueorangutan · 2026-07-06T17:20:04Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2026-07-06T17:23:51Z

Codecov Report

❌ Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.78%. Comparing base (98b8f75) to head (a516920).

Files with missing lines	Patch %	Lines
...java/com/cloud/agent/manager/AgentManagerImpl.java	12.50%	14 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #13552   +/-   ##
=========================================
  Coverage     20.78%   20.78%           
- Complexity    21941    21944    +3     
=========================================
  Files          6496     6496           
  Lines        591822   591837   +15     
  Branches      72615    72617    +2     
=========================================
+ Hits         123017   123028   +11     
- Misses       455450   455453    +3     
- Partials      13355    13356    +1

Flag	Coverage Δ
uitests	`3.88% <ø> (ø)`
unittests	`22.09% <12.50%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2026-07-06T18:25:33Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18480

Damans227 · 2026-07-06T19:46:30Z


    private void initConnectExecutor() {
-        _connectExecutor = new ThreadPoolExecutor(100, 500, 60L, TimeUnit.SECONDS, new LinkedBlockingQueue<>(), new NamedThreadFactory("AgentConnectTaskPool"));
+        _connectExecutor = new ThreadPoolExecutor(AgentConnectExecutorCorePoolSize.value(), AgentConnectExecutorMaxPoolSize.value(), 60L, TimeUnit.SECONDS, new LinkedBlockingQueue<>(), new NamedThreadFactory("AgentConnectTaskPool"));


Why no validation here? If max ends up lower than core, this throws and crashes management server startup. Maybe clamp the values before use so a bad config doesn't break things.

Thanks @Damans227 - added a validation. Can you please review?

Thanks @nvazquez, looks good. One question: should the max check be agentConnectMaxSize <= 0? ThreadPoolExecutor requires max to be strictly positive, so setting both keys to 0 passes validation but still throws at startup.

vladimirpetrov

LGTM based on manual testing. Tested with simultaneously restarting all the agents, which are more than the max pool size.

vladimirpetrov · 2026-07-10T16:29:29Z

@blueorangutan test

blueorangutan · 2026-07-10T16:30:04Z

@vladimirpetrov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-07-11T09:02:05Z

[SF] Trillian test result (tid-16525)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56284 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13552-t16525-kvm-ol8.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_upgrade_kubernetes_cluster	`Failure`	581.82	test_kubernetes_clusters.py

nvazquez · 2026-07-15T00:22:38Z

@blueorangutan package

blueorangutan · 2026-07-15T00:24:04Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-07-15T01:31:24Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18575

vladimirpetrov · 2026-07-15T14:58:49Z

@blueorangutan test

vladimirpetrov

LGTM, tested with core > max and invalid values.

nvazquez · 2026-07-16T02:01:41Z

@blueorangutan test

blueorangutan · 2026-07-16T02:04:04Z

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-07-16T17:16:12Z

[SF] Trillian test result (tid-16578)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51192 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13552-t16578-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

Damans227 · 2026-08-04T16:11:29Z

+        Pair<Integer, Integer> poolSizeValues = retrieveAgentConnectPoolCoreSizeAndMaxSize();
+        _connectExecutor = new ThreadPoolExecutor(poolSizeValues.first(), poolSizeValues.second(), 60L, TimeUnit.SECONDS, new LinkedBlockingQueue<>(), new NamedThreadFactory("AgentConnectTaskPool"));
        // allow core threads to time out even when there are no items in the queue
        _connectExecutor.allowCoreThreadTimeOut(true);


Same issue as before, just with 0 instead of max<core: agentConnectMaxSize < 0 lets 0 through, but ThreadPoolExecutor needs max strictly positive. So core=0, max=0 still passes validation and crashes at startup. Should this be <= 0?

…obal config (apache#839) Replaces hardcoded values of 100/500 in initConnectExecutor() with ConfigKeys agent.connect.executor.core.pool.size (default 100) and agent.connect.executor.max.pool.size (default 500).

nvazquez added this to the 4.22.2 milestone Jul 6, 2026

nvazquez requested review from Damans227, Pearl1594, sureshanaparti and vladimirpetrov July 6, 2026 17:15

nvazquez added the enhancement label Jul 6, 2026

boring-cyborg Bot added component:agent component:orchestration labels Jul 6, 2026

Damans227 reviewed Jul 6, 2026

View reviewed changes

vladimirpetrov approved these changes Jul 10, 2026

View reviewed changes

nvazquez requested a review from Damans227 July 15, 2026 00:22

vladimirpetrov approved these changes Jul 15, 2026

View reviewed changes

Damans227 reviewed Aug 4, 2026

View reviewed changes

DaanHoogland added this to CloudStack Testing Aug 31, 2026

github-project-automation Bot moved this to Backlog in CloudStack Testing Aug 31, 2026

DaanHoogland moved this from Backlog to In review in CloudStack Testing Sep 1, 2026

DaanHoogland removed the enhancement label Sep 5, 2026

nvazquez modified the milestones: 4.22.2, 4.22.3 Nov 9, 2026

sachindoddaguni and others added 3 commits November 9, 2026 23:52

Make AgentConnectTaskPool core and max pool sizes configurable via gl…

e91fcdf

…obal config (apache#839) Replaces hardcoded values of 100/500 in initConnectExecutor() with ConfigKeys agent.connect.executor.core.pool.size (default 100) and agent.connect.executor.max.pool.size (default 500).

Add validation for the setting values

7320773

Fix

a516920

nvazquez force-pushed the 422-agent-connect-task-pool-configurations branch from f4ec900 to a516920 Compare November 10, 2026 02:53

nvazquez changed the base branch from 4.22 to main November 10, 2026 02:53

boring-cyborg Bot added component:api component:build component:integration labels Nov 10, 2026

nvazquez modified the milestones: 4.22.3, 24.0 Nov 10, 2026

Conversation

nvazquez commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

nvazquez commented Jul 6, 2026

Uh oh!

blueorangutan commented Jul 6, 2026

Uh oh!

codecov Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jul 6, 2026

Uh oh!

Damans227 Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

nvazquez Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

Damans227 Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

vladimirpetrov left a comment

Choose a reason for hiding this comment

Uh oh!

vladimirpetrov commented Jul 10, 2026

Uh oh!

blueorangutan commented Jul 10, 2026

Uh oh!

blueorangutan commented Jul 11, 2026

Uh oh!

nvazquez commented Jul 15, 2026

Uh oh!

blueorangutan commented Jul 15, 2026

Uh oh!

blueorangutan commented Jul 15, 2026

Uh oh!

vladimirpetrov commented Jul 15, 2026

Uh oh!

vladimirpetrov left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Jul 16, 2026

Uh oh!

blueorangutan commented Jul 16, 2026

Uh oh!

blueorangutan commented Jul 16, 2026

Uh oh!

Damans227 Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nvazquez commented Jul 6, 2026 •

edited

Loading

codecov Bot commented Jul 6, 2026 •

edited

Loading