Conversation
d8d7edc to
04d74c2
Compare
There was a problem hiding this comment.
Pull request overview
Refactors the GitHub Actions CI configuration by consolidating repeated setup logic into composite actions and simplifying/merging coverage-related workflows.
Changes:
- Introduces composite actions for environment setup and installing the non-OSS dependencies.
- Refactors existing workflows (Build, RAT, Sonar, Simulator CI) to use the composite actions and adjusts concurrency behavior.
- Removes redundant workflows (
main-sonar-check.yml,codecov.yml) in favor of the updated jobs.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/sonar-check.yml | Combines PR + main branch Sonar execution and reuses composite actions. |
| .github/workflows/rat.yml | Refactors RAT checks to use composite actions and updated concurrency behavior. |
| .github/workflows/ci.yml | Refactors simulator CI and splits build/test via artifacts; updates matrix formatting. |
| .github/workflows/build.yml | Refactors build workflow to reuse composite actions. |
| .github/actions/setup-env/action.yml | New composite action to standardize Java/Python/APT dependency setup. |
| .github/actions/install-nonoss/action.yml | New composite action to standardize non-OSS install step. |
| .github/workflows/main-sonar-check.yml | Removed (superseded by updated sonar-check.yml). |
| .github/workflows/codecov.yml | Removed (coverage upload remains handled elsewhere). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/actions/setup-env/action.yml
Outdated
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: ${{ inputs.java-version }} |
There was a problem hiding this comment.
apt-get install list includes ipmitool twice. This is harmless but noisy; remove the duplicate entry to keep the dependency list maintainable.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #12774 +/- ##
=============================================
- Coverage 17.92% 3.66% -14.26%
=============================================
Files 5949 454 -5495
Lines 534058 38542 -495516
Branches 65301 7126 -58175
=============================================
- Hits 95742 1414 -94328
+ Misses 427560 36940 -390620
+ Partials 10756 188 -10568
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
04d74c2 to
388af20
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:243
- With the dedicated
.github/workflows/codecov.ymlremoved, it looks like Codecov uploads are now limited to this integration-test coverage file. If unit-test/aggregate coverage (e.g. the previousclient/target/site/jacoco-aggregate/jacoco.xml) is still desired for Codecov, it should be uploaded from an appropriate workflow/job as well, otherwise overall coverage reporting will change.
- uses: codecov/codecov-action@v4
with:
files: jacoco-coverage.xml
fail_ci_if_error: true
flags: simulator-marvin-tests
verbose: true
name: codecov
token: ${{ secrets.CODECOV_TOKEN }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eac44e9 to
bffe192
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bffe192 to
402c233
Compare
402c233 to
146ec06
Compare
Description
This PR refactors the github actions.
This pull request refactors the GitHub Actions workflows for CloudStack to improve maintainability, modularity, and efficiency. The main changes include the creation and use of composite actions for environment setup and non-OSS installation, streamlining build and CI workflows, and optimizing artifact handling between build and test jobs.
Workflow modularization and simplification:
Introduced new composite actions:
setup-envsets up JDK, Python, and APT dependencies, andinstall-nonossinstalls the non-OSS components, reducing duplicated steps in workflow files (.github/actions/setup-env/action.yml,.github/actions/install-nonoss/action.yml). [1] [2]Updated
build.ymlandci.ymlworkflows to use these composite actions, replacing manual setup steps with reusable actions for environment preparation and non-OSS installation (.github/workflows/build.yml,.github/workflows/ci.yml). [1] [2] [3] F383a9b5L60R44)Artifact management improvements:
.github/workflows/ci.yml).Cleanup and optimization:
.github/workflows/ci.yml). [1] [2] [3]Test matrix formatting:
.github/workflows/ci.yml).These changes make the workflows easier to maintain, reduce duplication, and improve CI/CD efficiency.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?