Skip to content

Change disk-only VM snapshot removal message#11182

Open
JoaoJandre wants to merge 3 commits intoapache:mainfrom
scclouds:change-gui-message
Open

Change disk-only VM snapshot removal message#11182
JoaoJandre wants to merge 3 commits intoapache:mainfrom
scclouds:change-gui-message

Conversation

@JoaoJandre
Copy link
Contributor

Description

This PR changes the warning given to users when deleting disk-only VM snapshots on KVM. When deleting disk-only VM snapshots on KVM, the VM is not paused.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

When deleting Disk-only VM snapshot:
image

When deleting Disk And Memory VM snapshot:
image

How Has This Been Tested?

Created two VM snapshots, one with and one without memory. I checked that the messages were being shown accordingly.

@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.92%. Comparing base (74af9b9) to head (43e3805).

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11182   +/-   ##
=========================================
  Coverage     17.92%   17.92%           
- Complexity    16175    16178    +3     
=========================================
  Files          5949     5949           
  Lines        534058   534061    +3     
  Branches      65301    65301           
=========================================
+ Hits          95742    95749    +7     
+ Misses       427560   427556    -4     
  Partials      10756    10756           
Flag Coverage Δ
uitests 3.66% <ø> (-0.01%) ⬇️
unittests 19.03% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11182 (QA-JID-829)

@kiranchavala
Copy link
Member

@blueorangutan ui

@blueorangutan
Copy link

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@kiranchavala
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@kiranchavala kiranchavala self-assigned this Jan 29, 2026
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16611

@kiranchavala
Copy link
Member

@JoaoJandre

Looks like there is some caching issue

  1. Launched 2 vms ( vm1, vm2)

  2. Take a vm snapshot with disk and memory for vm 1

  3. Take a vm snapshot with disk for vm 2

In a incognito window, try to delete the vm snapshots ,we get the same error message

Screen.Recording.2026-01-29.at.6.22.56.PM.mov
Screen.Recording.2026-01-29.at.6.20.22.PM.mov

@JoaoJandre
Copy link
Contributor Author

@kiranchavala I think there might've been an issue with the version that I was basing this PR on. I have merged the main branch on my branch and tested and it looks good. Could you test again?
If you find an issue, could you detail which steps you took to get to the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants