Repository navigation
Fix double KeyboardInterrupt on PL/Python cancel - #2185
Open
krylosov-aa wants to merge 1 commit into
Open
krylosov-aa wants to merge 1 commit into
krylosov-aa wants to merge 1 commit into
Conversation
Timeouts and client cancel requests could send duplicate signals, interrupting Python cleanup or a later call. Signal the process group once with a backend fallback, and ignore stale Python callbacks. Fixes apache#2181
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2181
What does this PR do?
Avoid duplicate cancel signals and ignore stale Python callbacks, preventing a second KeyboardInterrupt from interrupting cleanup or affecting the next PL/Python call.
Type of Change
Test Plan
Passed
cancel_plpythonwith both planners on Linux ARM64 / Python 3.10.Verified client cancellation, repeated cancellation, and statement/lock timeouts.
Checklist