Skip to content

Restore fault hooks and legacy TOAST chunk reads - #2179

Draft
reshke wants to merge 1 commit into
apache:mainfrom
reshke:fix-fault-hook-contracts
Draft

reshke wants to merge 1 commit into
apache:mainfrom
reshke:fix-fault-hook-contracts

Conversation

@reshke

@reshke reshke commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Restore the TOAST chunk-size, WindowAgg spool, and diskquota error hooks used by regression tests. Read legacy TOAST values using their actual chunk size, and make tests check that the requested faults fired.

Reject malformed and out-of-range GPFDIST_WATCHDOG_TIMER values before converting them to int. Add CLI regression coverage and update affected expected results, including the PAX test copies.

Validation on the prepared server build: toast, misc_jiras, statement_mem_for_windowagg, test_fetch_table_stat, and the gpfdist watchdog target passed. Additional checks covered 936 TOAST slices and compressed values. A clean build of the current main branch was not run.

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


Restore the TOAST chunk-size, WindowAgg spool, and diskquota error hooks
used by regression tests. Read legacy TOAST values using their actual
chunk size, and make tests check that the requested faults fired.

Reject malformed and out-of-range GPFDIST_WATCHDOG_TIMER values before
converting them to int. Add CLI regression coverage and update affected
expected results, including the PAX test copies.

Validation on the prepared server build: toast, misc_jiras,
statement_mem_for_windowagg, test_fetch_table_stat, and the gpfdist
watchdog target passed. Additional checks covered 936 TOAST slices and
compressed values. A clean build of the current main branch was not run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant