CEP-50/CASS-21334: Server negotiates authenticator per client connection#4773
Open
jcshepherd wants to merge 31 commits intoapache:trunkfrom
Open
CEP-50/CASS-21334: Server negotiates authenticator per client connection#4773jcshepherd wants to merge 31 commits intoapache:trunkfrom
jcshepherd wants to merge 31 commits intoapache:trunkfrom
Conversation
… (CASSANDRA-20834 for CEP-50) With negotiated authentication (CEP-50), nodes may be configured with multiple authenticators. Prior to this change, a number of areas in the code assumed that there was a single configured authenticator and contained logic that switched depending on the authenticator type. This logic won't work when multiple authenticators can be configured. This change eliminates most calls to DataDescriptor.getAuthenticator(), by enabling individual authenticators to declare the role attributes they support, requiring callers to specify the type of authenticator they're looking for, and directly returning whether the node can enforce authn or not rather than inferring it by the presence of an authenticator. Testing done: Unit tests for auth and config packages; d-tests for auth-related functionality (e.g. ColumnMasks). patch by jcshepherd; reviewed by smiklosovic,tolbertam for CASSANDRA-20834
…RA-20834) With negotiated authentication (CEP-50), nodes may be configured with multiple authenticators. Prior to this change, a number of areas in the code assumed that there was a single configured authenticator and contained logic that switched depending on the authenticator type. This logic won't work when multiple authenticators can be configured. This change eliminates most calls to DataDescriptor.getAuthenticator(), by either requiring dependencies to specify the type of authenticator they're looking for, or (in the case of authenticator-specific role attributes) enabling individual authenticators to declare the role attributes they need. patch by jcshepherd; reviewed by <Reviewers> for CASSANDRA-20834
…to DatabaseDescriptor.unsafeDaemonInitialization() in AuthConfigTest to enable each test to run against the appropriate auth config. (DatabaseDescriptor.daemonInitialization() can be invoked only once per unit test class execution and is not suitable for test cases exercising multiple configuration scenarios.)
…Code() computations
…basic negotiation mechanism
…d STARTUP messages
… an object, not a list, and adding notes on why it matters. Still a sharp edge ...
…abled during node initialization, when all clients are system/internal
… handshake, client super- and anonymous-user determination is made based on the authenticator used by the client, not the node's default authenticator
…d of StorageService. Auth setup includes ensuring all negotiable authenticators are initialized.
…emon to set up auth
…ator. Test updates to initialize client state and use a marker class to distinguish between authenticator returned by default vs by negotiation
…ured authenticator requires authentication. ClientState disallows anonymous (unauthenticated) users from assuming super user privileges if any configured authenticator requires authentication.
…thentication, and validates authorizer compatibility with the authentication configuration
… with and without auth negotiation enabled
… in InitConnectionHandler
# Conflicts: # src/java/org/apache/cassandra/config/DatabaseDescriptor.java # src/java/org/apache/cassandra/service/ClientState.java # src/java/org/apache/cassandra/transport/messages/StartupMessage.java # test/unit/org/apache/cassandra/auth/AuthConfigTest.java
…ded reasonable default values
…d cache in PasswordAuthenticator as a singleton, minor code and comment clean-up elsewhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server negotiates authenticator per client connection.
This is the main server-side implementation of CEP-50 (https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-50%3A+Authentication+Negotiation), enabling administrators to configure authentication negotiation with multiple authenticator options, and the server to negotiate an authenticator with the client for each connection. Clients that don't support authentication can connect and authenticate as they always have.
Heaviest changes are in AuthConfig and DatabaseDescriptor. Negotiation itself is pretty lightweight.
There are a couple areas I'd really like a second opinion on:
patch by jcshepherd; reviewed by for CASSANDRA-21334
Assisted-by: Amazon Q CLI 1.19.6 claude-sonnet-4.5