Mark non-security md5 usage to allow for compatibility with fips environments#1288
Open
lratc wants to merge 1 commit intoapache:trunkfrom
Open
Mark non-security md5 usage to allow for compatibility with fips environments#1288lratc wants to merge 1 commit intoapache:trunkfrom
lratc wants to merge 1 commit intoapache:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per python/cpython#53462 hashlib.md5() takes an implicit "usedforsecurity=True" argument. In a FIPS-140 environment, this causes the cassandra-python-driver to error as md5 is not permitted for security usage.
ModuleNotFoundError: No module named 'md5'Within the context of this package, the token is not used for security - this is used for an internal hashing function only, so marking it as usedforsecurity=False is a straightforward method to permit its usage without affecting compatibility.