Skip to content

Camel Zookeeper Cluster Split brain issue when leader is isolated #25529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mustafaAlmonayer wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −4
Open

Camel Zookeeper Cluster Split brain issue when leader is isolated #25529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions ...eper/src/main/java/org/apache/camel/component/zookeeper/cluster/ZooKeeperClusterView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ final class ZooKeeperClusterView extends AbstractCamelClusterView {
private final CuratorFramework client;
private final CuratorLocalMember localMember;
private volatile LeaderSelector leaderSelector;
private volatile boolean leader;

public ZooKeeperClusterView(CamelClusterService cluster, ZooKeeperCuratorConfiguration configuration,
CuratorFramework client, String namespace) {
Expand Down Expand Up @@ -110,6 +111,7 @@ protected void doStart() throws Exception {
if (leaderSelector == null) {
leaderSelector = new LeaderSelector(client, getFullPath(), new CamelLeaderElectionListener());
leaderSelector.setId(getClusterService().getId());
leaderSelector.autoRequeue();
leaderSelector.start();
} else {
leaderSelector.requeue();
Expand All @@ -119,8 +121,9 @@ protected void doStart() throws Exception {
@Override
protected void doStop() throws Exception {
if (leaderSelector != null) {
leader = false;
leaderSelector.interruptLeadership();
fireLeadershipChangedEvent(getLeader().orElse(null));
fireLeadershipChangedEvent((CamelClusterMember) null);
}
}

Expand All @@ -142,15 +145,20 @@ private String getFullPath() {
private final class CamelLeaderElectionListener extends LeaderSelectorListenerAdapter {
@Override
public void takeLeadership(CuratorFramework curatorFramework) throws Exception {
leader = true;
fireLeadershipChangedEvent(localMember);

BlockingTask task = Tasks.foregroundTask().withBudget(Budgets.iterationBudget()
.withMaxIterations(IterationBoundedBudget.UNLIMITED_ITERATIONS)
.withInterval(Duration.ofSeconds(5))
.build())
.build();

task.run(getCamelContext(), () -> !isRunAllowed());
try {
task.run(getCamelContext(), () -> !isRunAllowed() || !leaderSelector.hasLeadership());
} finally {
leader = false;
fireLeadershipChangedEvent((CamelClusterMember) null);
}

fireLeadershipChangedEvent(getLeader().orElse(null));
}
Expand All @@ -159,7 +167,7 @@ public void takeLeadership(CuratorFramework curatorFramework) throws Exception {
private final class CuratorLocalMember implements CamelClusterMember {
@Override
public boolean isLeader() {
return leaderSelector != null && leaderSelector.hasLeadership();
return leader;
}

@Override
Expand Down