chore(test): make DDB Scan/Query IT assertions order-independent#23242
Merged
Conversation
DynamoDB Scan does not guarantee item ordering. The tests were relying on a specific item order that happened to match LocalStack's internal storage layout, making them fail against other DynamoDB-compatible backends. Assert on value sets and structural properties instead.
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
All tested modules (8 modules)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AWS2QueryRuleITandAWS2ScanRuleITwere asserting specific values atitems.get(0), relying on LocalStack's internal storage orderCollectors.toSet()and structural iteration over all itemskeyConditionsandcollvariables) from the affected test methodsTest plan
camel-aws2-ddbintegration tests pass with LocalStackcamel-aws2-ddbintegration tests pass with Floci (an alternative AWS emulator that returns Scan items in a different order)