CAMEL-23485: camel-diagram - Add ASCII art and Unicode text renderers#23152
CAMEL-23485: camel-diagram - Add ASCII art and Unicode text renderers#23152davsclaus wants to merge 8 commits into
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ommand Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…racters Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…evConsole Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
🧪 CI tested the following changed modules:
💡 Manual integration tests recommended:
Build reactor — dependencies compiled but only changed modules were tested (4 modules)
|
davsclaus
left a comment
There was a problem hiding this comment.
Review: CAMEL-23485
Overall this looks good — clean separation of concerns, backwards-compatible SPI changes, and solid test coverage (14 new tests).
Findings
1. diagram.adoc line 20 — "(PNG only)" on scope boxes is now inaccurate
Since this PR adds scope boxes to ASCII/Unicode rendering, the annotation (PNG only) should be removed from the scope boxes bullet point.
2. Unused constants UNI_T_RIGHT and UNI_T_LEFT
RouteDiagramAsciiRenderer.java declares UNI_T_RIGHT (├) and UNI_T_LEFT (┤) but they are never referenced. Consider removing to avoid dead code, or adding a comment if they're intended for future use.
3. plotLine() — parentheses for clarity
The condition isVertical(current) && isHorizontal(ch) || isHorizontal(current) && isVertical(ch) is correct due to operator precedence but would be clearer with explicit parentheses.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
RouteDiagramAsciiRendererthat renders route diagrams as plain text using the sameRouteDiagramLayoutEngineas the PNG renderer--theme=ascii(plain+-|v) and--theme=unicode(box-drawing┌──┐ │ └──┘ ▼)- - -/:for ASCII,╌/╎for Unicode).txtfilesCamelRouteDiagramAction(JBang CLI),DiagramDevConsole, andRouteDiagramDumperSPITest plan
CamelRouteDiagramActionClaude Code on behalf of Claus Ibsen
🤖 Generated with Claude Code