CAMEL-23224: Switch JBang shell to JLine 4 PicocliCommandRegistry#22184
Closed
CAMEL-23224: Switch JBang shell to JLine 4 PicocliCommandRegistry#22184
Conversation
- Replace picocli-shell-jline3 with JLine 4's built-in jline-picocli module which provides PicocliCommandRegistry with proper argument completion via picocli's AutoComplete - Simplify Shell.java using JLine 4's Shell.builder() API - Bump JLine version to 4.0.8-1-SNAPSHOT (pending JLine release) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
oscerd
approved these changes
Mar 23, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Claude Code on behalf of Guillaume Nodet Closing — the completion fix (JLine 4.0.8 bump) has been merged into #22170 which is the superset PR. |
Contributor
|
🧪 CI tested the following changed modules:
Build reactor — dependencies compiled but only changed modules were tested (4 modules)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
picocli-shell-jline3with JLine 4's built-injline-picoclimodule (PicocliCommandRegistry) which provides proper argument completion via picocli'sAutoCompleteShell.javafrom ~140 lines of manual JLine setup to ~20 lines using JLine 4'sShell.builder()APIBefore
The
camel shellREPL only completed command names — no completion for options, option values, or positional parameters.After
Full argument completion powered by picocli's
AutoComplete.complete(): options, option values, positional parameters, completion candidates, and nested subcommands all complete properly.Test plan
camel-jbang-corecompiles with JLine 4.0.8 releasecamel shellwith tab completion for command arguments