Opentelemetry test failure - revert latest changes

[apupier]

Description

org.opentest4j.AssertionFailedError: No metric data found with name A ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
	at org.apache.camel.opentelemetry.metrics.integration.TimerRouteAutoConfigIT.testOverrideMetricsName(TimerRouteAutoConfigIT.java:119)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

Given that the component will surely be deprecated soon as there is opentelemtry2 component and the changes were only to fix warnings, I think i tis easier to revert the change and let it back to previous state where the test was TimerRouteAutoConfigIT.testOverrideMetricsName was working

Target

• I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

• If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

• I checked that each commit in the pull request has a meaningful subject line and body.

• I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run

• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

• You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

• Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

• ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[squakez]

I am not sure to understand. Why this change is going to fix an error happening in another component? the failure, according to the trace, belongs to camel-opentelemetry-metrics which should have nothing to do with camel-opentelemetry

[apupier]

I am not sure to understand. Why this change is going to fix an error happening in another component? the failure, according to the trace, belongs to camel-opentelemetry-metrics which should have nothing to do with camel-opentelemetry

good point.
So I guess the test is flaky only and I really had no chance to fail several times without reverting and succeed several times with the revert.
I do not see a dependency from camel-opentelemetry-metrics to camel-opentelemetry

i will look again tomorrow

[apupier]

I reproduced the failure one time this morning and now it is always passing. SO this is a flaky test, completely unrelated to the change of this PR. My bad.

[squakez]

No worries. Please, report it as a flaky test on Jira and we will eventually solve it.