CAMEL-22898: Fix memory leak in Google PubSub consumer #21209
Merged
+94
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
oscerd
approved these changes
Feb 2, 2026
When a subscription doesn't exist, the subscriber.startAsync().awaitRunning() call throws a NotFoundException. However, the subscriber was being added to the subscribers list BEFORE this call, causing it to accumulate in the list on repeated failures. This fix: 1. Moves the subscribers.add() call to AFTER successful startup 2. Adds proper cleanup in catch block to remove subscribers on failure 3. Adds a 5-second backoff delay to prevent tight loop on persistent failures 4. Ensures cleanup in finally block Applied to both GooglePubsubConsumer and GooglePubsubLiteConsumer.
gnodet
force-pushed
the
CAMEL-22898-fix-pubsub-memory-leak
branch
from
b79c7bd to
f7efc21
Compare
davsclaus
reviewed
Feb 2, 2026
...ite/src/main/java/org/apache/camel/component/google/pubsublite/GooglePubsubLiteConsumer.java
Outdated
Show resolved
Hide resolved
davsclaus
approved these changes
Feb 2, 2026
Croway
approved these changes
Feb 2, 2026
…rors Enhanced error handling to distinguish between recoverable and non-recoverable errors using ApiException.isRetryable(): - Recoverable errors (e.g., ABORTED, UNAVAILABLE, UNKNOWN): Continue retrying with 5-second backoff delay - Non-recoverable errors (e.g., NotFoundException, permission errors): Exit the subscriber loop immediately without retrying This prevents infinite retry loops for errors that cannot be recovered, while still allowing automatic recovery from transient failures. Applied to both GooglePubsubConsumer and GooglePubsubLiteConsumer.
… delays Replaced Thread.sleep() with Tasks.foregroundTask() using IterationBudget to implement the 5-second backoff delay for recoverable errors. This integrates better with Camel's task management framework. Applied to both GooglePubsubConsumer and GooglePubsubLiteConsumer.
gnodet
force-pushed
the
CAMEL-22898-fix-pubsub-memory-leak
branch
from
2c35419 to
9fda7c8
Compare
The ForegroundTask only sleeps between iterations, not before the first iteration. For a one-time delay with maxIterations(1), we must use withInitialDelay() to ensure the delay happens before the first iteration. This fixes the backoff delay in both GooglePubsubConsumer and GooglePubsubLiteConsumer.
Resolved conflict in GooglePubsubConsumer.java by keeping both the new UnitOfWorkHelper import from main and our Task API imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes memory leak in Google PubSub consumer when subscription doesn't exist.
Problem
When a subscription no longer exists, starting a subscriber throws a
NotFoundException. However, the subscriber was being added to thesubscriberslist BEFORE thestartAsync().awaitRunning()call. This caused subscribers to accumulate in the list on repeated failures, leading to unbounded memory growth until JVM runs out of memory.Additionally, there was no backoff delay, causing a tight loop that consumed CPU resources.
Solution
This fix addresses the issue in both
GooglePubsubConsumerandGooglePubsubLiteConsumer:Testing
Related Issue
https://issues.apache.org/jira/browse/CAMEL-22898
Pull Request opened by Augment Code with guidance from the PR author