Fix #6806: remove deprecated delete, get and kit kamel commands - #6816
Open
rrafifnanda wants to merge 1 commit into
Open
rrafifnanda wants to merge 1 commit into
rrafifnanda wants to merge 1 commit into
Conversation
Removes the deprecated delete, get and kit CLI implementations along with their unit tests and deregisters them from the root command. E2E updates per maintainer feedback: drops the dedicated kamel delete suite, replaces kamel delete cleanup calls with kubectl delete it, switches the get help case to run help, and updates the running-cli docs example to kubectl get integrations.
rrafifnanda
force-pushed
the
feature/6806-remove-deprecated-commands
branch
from
September 15, 2026 16:12
bbcfc83 to
8152fd4
Compare
squakez
reviewed
Sep 16, 2026
| return kamelTestPreAddCommandInitWithClient(fakeClient) | ||
| } | ||
|
|
||
| func TestDeprecatedCommandsAreNotRegistered(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Maybe we can remove this test. We don't really care to check any removed subcommand.
gansheer
approved these changes
Sep 16, 2026
Contributor
|
✔️ Unit test coverage report - coverage increased from 63.8% to 64.4% (+0.6%) |
Contributor
|
It seems the We need to replace that logic accordingly. There is also some failure on Keda, we will need to understand it as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6806
Removes the already deprecated
kamelsubcommandsdelete,get, andkit:pkg/cmd/delete.go,get.go,kit*.goand their command-specific unit testspkg/cmd/root.go+ addsTestDeprecatedCommandsAreNotRegisteredkamel deleteE2E suite (e2e/common/cli/delete_test.go)kamel deletecalls withkubectl delete itper maintainer feedback on Drop 2.9 CLI deprecated commands #6806 (comment) (coverse2e/advanced/debug_test.go,e2e/common/traits/master_test.go,route_test.go,e2e/kafka/*,e2e/knative/*, andDeleteIntegrationsine2e/support/test_support.go)get helpcase withrun -hand changes therunning-cli.adocexample tokubectl get integrationsVerification:
go test ./pkg/cmd/... -count=1passesgo vet -tags integrationon touched E2E packages passes./cmd/kameland confirmeddelete/get/kitreport unknown command and no longer appear in helpClaude Code on behalf of @rrafifnanda