[CALCITE-7685] Filter unresolved function overloads by argument count during early resolution - #5140
Open
dssysolyatin wants to merge 1 commit into
Open
[CALCITE-7685] Filter unresolved function overloads by argument count during early resolution#5140dssysolyatin wants to merge 1 commit into
dssysolyatin wants to merge 1 commit into
Conversation
… during early resolution
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7685
Changes Proposed
Filter unresolved function overloads by argument count during early resolution.
As part of this change, SqlUnresolvedFunction#argumentMustBeScalar must return false. With arity filtering, a wrong-arity call to a table function such as TUMBLE stays unresolved at the point where sub-queries are registered. The default value (true) would wrap its TABLE argument in an internal $SCALAR_QUERY call, and validation would then fail error ("Cannot apply '$SCALAR_QUERY' ...") instead of the expected arity error.