Add test cases for SetOpToFilterRule to verify that PROJECT containing non-deterministic expressions and subqueries are not merged#4864
Merged
xiedeyantu merged 1 commit intoapache:mainfrom Apr 4, 2026
Conversation
…g non-deterministic expressions and subqueries are not merged
|
caicancai
approved these changes
Apr 4, 2026
xiedeyantu
added
the
LGTM-will-merge-soon
Member
Author
|
@caicancai Thanks for your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
Changes Proposed
Add test cases for SetOpToFilterRule to verify that PROJECT containing non-deterministic expressions and subqueries are not merged.
Although we previously discussed freezing
RelOptRulesTest, this merely serves to enrich the validation for a specific scenario. I am not entirely sure whether it is appropriate to incorporate this intoRelOptRulesTest. Furthermore, Julian's refactoring of the testing framework has not yet been completed.